-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make switch_direction
consistent
#639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
===========================================
- Coverage 98.87% 40.49% -58.39%
===========================================
Files 106 106
Lines 10206 10081 -125
===========================================
- Hits 10091 4082 -6009
- Misses 115 5999 +5884
... and 80 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think this should be more or less ready. @olivierverdier , do you think this solves the issue? I was trying to make the default close to what we currently have but now you can express all four options and switch just the left/right or forward/backward part of the action. Rotation and translation actions are all forward now. |
It does solve the issue, thank you! |
This PR implements a solution that will resolve #637 by introducing four different action directions instead of just two.
TODO: